diff options
author | Nick Mathewson <nickm@torproject.org> | 2009-01-28 17:36:41 +0000 |
---|---|---|
committer | Nick Mathewson <nickm@torproject.org> | 2009-01-28 17:36:41 +0000 |
commit | e06de61d84e3c0fc152edeb622246baeb637874a (patch) | |
tree | 5035ec1b3f361efdef52713aee4cd0ad41ccc50d /ChangeLog | |
parent | 62a460d55fba032ace5795429648963d01f63a6c (diff) | |
download | tor-e06de61d84e3c0fc152edeb622246baeb637874a.tar.gz tor-e06de61d84e3c0fc152edeb622246baeb637874a.zip |
Don't obsolete a very-new connection for having no circuits yet.
This fixes the last known case of bug 891, which could happen if two
hosts, A and B, disagree about how long a circuit has been open,
because of clock drift of some kind. Host A would then mark the
connection as is_bad_for_new_circs when it got too old and open a new
connection. In between when B receives a NETINFO cell on the new
conn, and when B receives a conn cell on the new circuit, the new
circuit will seem worse to B than the old one, and so B will mark it
as is_bad_for_new_circs in the second or third loop of
connection_or_group_set_badness().
Bugfix on 0.1.1.13-alpha. Bug found by rovv.
Not a backport candidate: the bug is too obscure and the fix too tricky.
svn:r18303
Diffstat (limited to 'ChangeLog')
-rw-r--r-- | ChangeLog | 5 |
1 files changed, 5 insertions, 0 deletions
@@ -15,6 +15,11 @@ Changes in version 0.2.1.12-alpha - 2009-02-?? headers. Bugfix on 0.2.0.10-alpha. - Don't consider consider expiring already-closed client connections. Fixes bug 893. Bugfix on 0.0.2pre20. + - Fix another interesting corner-case of bug 891 spotted by rovv: + Previously, if two hosts had different amounts of clock drift, and one + of them created a new connection with just the wrong timing, the other + might decide to deprecate the new connection erroneously. Bugfix on + 0.1.1.13-alpha. o Minor features: - Support platforms where time_t is 64 bits long. (Congratulations, |