summaryrefslogtreecommitdiff
path: root/ChangeLog
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2019-10-17 13:13:52 -0400
committerNick Mathewson <nickm@torproject.org>2019-10-22 07:50:13 -0400
commite07b19d3055f9ce080efaf2295f1ca096b10db3c (patch)
treef875fb6f07549d1bd7d3d6aab8ae3c1fa6e51123 /ChangeLog
parentdb18ff91208e0065c38e5f4d0dd57eb8a0ae513c (diff)
downloadtor-e07b19d3055f9ce080efaf2295f1ca096b10db3c.tar.gz
tor-e07b19d3055f9ce080efaf2295f1ca096b10db3c.zip
Rationalize handling of quiet_level in config.c
Formerly, we would use quiet_level as an excuse to rewrite the log configuration, adding a default log line if none existed, and if RunAsDaemon was not set, and if we were not being invoked via setconf (!). This is against our best practices for several reasons: * We should not be changing configured options except when the user tells us to do so. * We should especially not be changing options in the options_validate function. * Distinguishing whether we are being called from setconf adds a risky special-case. Instead, this patch take a simpler approach: it changes the interpretation of having no logging lines set to mean: If there is a stdout, add a default log based on quiet_level. Solves ticket 31999.
Diffstat (limited to 'ChangeLog')
0 files changed, 0 insertions, 0 deletions