summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorteor <teor@torproject.org>2020-03-19 17:11:13 +1000
committerteor <teor@torproject.org>2020-03-19 17:11:13 +1000
commitc862205ba5b9954fe9dbc22a104238a3c04951a8 (patch)
treee57d5d172c1b0f0de740cbd8c4b2d119a5e637fc
parentfe5ecaa270b037e76226bd7acda10a14611eef93 (diff)
downloadtor-c862205ba5b9954fe9dbc22a104238a3c04951a8.tar.gz
tor-c862205ba5b9954fe9dbc22a104238a3c04951a8.zip
coverity: Silence spurious unreachable warning
Closes bug 33641; not in any released version of tor.
-rw-r--r--src/test/test_circuitbuild.c4
-rw-r--r--src/test/test_dir.c4
2 files changed, 8 insertions, 0 deletions
diff --git a/src/test/test_circuitbuild.c b/src/test/test_circuitbuild.c
index 8b506011b0..10d78abc35 100644
--- a/src/test/test_circuitbuild.c
+++ b/src/test/test_circuitbuild.c
@@ -115,8 +115,12 @@ test_new_route_len_unhandled_exit(void *arg)
(void)arg;
#ifdef ALL_BUGS_ARE_FATAL
+ /* Coverity (and maybe clang analyser) complain that the code following
+ * tt_skip() is unconditionally unreachable. */
+#if !defined(__COVERITY__) && !defined(__clang_analyzer__)
tt_skip();
#endif
+#endif
MOCK(count_acceptable_nodes, mock_count_acceptable_nodes);
diff --git a/src/test/test_dir.c b/src/test/test_dir.c
index e6f87dbd32..bf9a04b079 100644
--- a/src/test/test_dir.c
+++ b/src/test/test_dir.c
@@ -4992,8 +4992,12 @@ test_dir_purpose_needs_anonymity_returns_true_by_default(void *arg)
(void)arg;
#ifdef ALL_BUGS_ARE_FATAL
+ /* Coverity (and maybe clang analyser) complain that the code following
+ * tt_skip() is unconditionally unreachable. */
+#if !defined(__COVERITY__) && !defined(__clang_analyzer__)
tt_skip();
#endif
+#endif
tor_capture_bugs_(1);
setup_full_capture_of_logs(LOG_WARN);