diff options
| author | Nick Mathewson <nickm@torproject.org> | 2017-02-28 11:19:24 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2017-02-28 11:19:24 -0500 |
| commit | ef610467fa5122740cb7a964376a440f31c41696 (patch) | |
| tree | 25cbdfb541c9018da791fa7944ee03c0323ed690 | |
| parent | 242f9b3ffb6c100de5b9eb2cbccecbf07c68554f (diff) | |
| parent | 57154e71aa3b0ff205f2700e97f0ffe4531e1330 (diff) | |
| download | tor-ef610467fa5122740cb7a964376a440f31c41696.tar.gz tor-ef610467fa5122740cb7a964376a440f31c41696.zip | |
Merge remote-tracking branch 'teor/bug21507-029'
| -rw-r--r-- | changes/bug21507 | 5 | ||||
| -rw-r--r-- | src/or/routerparse.c | 2 |
2 files changed, 7 insertions, 0 deletions
diff --git a/changes/bug21507 b/changes/bug21507 new file mode 100644 index 0000000000..f83e291b63 --- /dev/null +++ b/changes/bug21507 @@ -0,0 +1,5 @@ + o Minor bugfixes (voting consistency): + - Reject version numbers with non-numeric prefixes (such as +, -, and + whitespace). Disallowing whitespace prevents differential version + parsing between POSIX-based and Windows platforms. + Fixes bug 21507 and part of 21508; bugfix on 0.0.8pre1. diff --git a/src/or/routerparse.c b/src/or/routerparse.c index 98167d44f8..0336c035b4 100644 --- a/src/or/routerparse.c +++ b/src/or/routerparse.c @@ -4894,6 +4894,8 @@ tor_version_parse(const char *s, tor_version_t *out) #define NUMBER(m) \ do { \ + if (!cp || *cp < '0' || *cp > '9') \ + return -1; \ out->m = (int)tor_parse_uint64(cp, 10, 0, INT32_MAX, &ok, &eos); \ if (!ok) \ return -1; \ |