summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2018-08-08 09:26:23 -0400
committerNick Mathewson <nickm@torproject.org>2018-08-08 09:26:23 -0400
commit7787150521fda0370331dab80d043294e05e1598 (patch)
tree0154ec7cf555d1ab0ca36f7007a956aa2b6bec73
parent3a2b5a5bcbb35cdedfb63a00391bbf15df69cd9b (diff)
parentaaa5ca366e83795f3ec7b35e879a3c8bc4e0b41f (diff)
downloadtor-7787150521fda0370331dab80d043294e05e1598.tar.gz
tor-7787150521fda0370331dab80d043294e05e1598.zip
Merge branch 'maint-0.3.4'
-rw-r--r--changes/bug254405
-rw-r--r--src/lib/sandbox/sandbox.c2
2 files changed, 6 insertions, 1 deletions
diff --git a/changes/bug25440 b/changes/bug25440
new file mode 100644
index 0000000000..f8d9dd4fab
--- /dev/null
+++ b/changes/bug25440
@@ -0,0 +1,5 @@
+ o Minor bugfixes (linux seccomp2 sandbox):
+ - Fix a bug in out sandboxing rules for the openat() syscall.
+ Previously, no openat() call would be permitted, which would break
+ filesystem operations on recent glibc versions. Fixes bug 25440;
+ bugfix on 0.2.9.15. Diagnosis and patch from Daniel Pinto.
diff --git a/src/lib/sandbox/sandbox.c b/src/lib/sandbox/sandbox.c
index 5510754327..48e37ba127 100644
--- a/src/lib/sandbox/sandbox.c
+++ b/src/lib/sandbox/sandbox.c
@@ -455,7 +455,7 @@ allow_file_open(scmp_filter_ctx ctx, int use_openat, const char *file)
{
if (use_openat) {
return seccomp_rule_add_2(ctx, SCMP_ACT_ALLOW, SCMP_SYS(openat),
- SCMP_CMP_STR(0, SCMP_CMP_EQ, AT_FDCWD),
+ SCMP_CMP(0, SCMP_CMP_EQ, (unsigned int)AT_FDCWD),
SCMP_CMP_STR(1, SCMP_CMP_EQ, file));
} else {
return seccomp_rule_add_1(ctx, SCMP_ACT_ALLOW, SCMP_SYS(open),