summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorrl1987 <rl1987@sdf.lonestar.org>2019-01-18 13:49:30 +0200
committerrl1987 <rl1987@sdf.lonestar.org>2019-01-18 13:49:30 +0200
commit88818eacbdcbdd1fddb3452c3eddf8fba3f26e9c (patch)
tree09a0a6aff966552c61b2dde7335b99c6e0972f22
parent81f1b89efc94723f2c13b0b80d311364a2245d85 (diff)
downloadtor-88818eacbdcbdd1fddb3452c3eddf8fba3f26e9c.tar.gz
tor-88818eacbdcbdd1fddb3452c3eddf8fba3f26e9c.zip
Cleanup shellcheck warnings in autogen.sh
-rwxr-xr-xautogen.sh5
-rw-r--r--changes/ticket260692
2 files changed, 5 insertions, 2 deletions
diff --git a/autogen.sh b/autogen.sh
index 276dd4047c..63ef6d49ef 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -1,9 +1,9 @@
#!/bin/sh
-if [ -x "`which autoreconf 2>/dev/null`" ] ; then
+if command -v autoreconf; then
opt="-i -f -W all,error"
- for i in $@; do
+ for i in "$@"; do
case "$i" in
-v)
opt="${opt} -v"
@@ -11,6 +11,7 @@ if [ -x "`which autoreconf 2>/dev/null`" ] ; then
esac
done
+ # shellcheck disable=SC2086
exec autoreconf $opt
fi
diff --git a/changes/ticket26069 b/changes/ticket26069
new file mode 100644
index 0000000000..caed9be348
--- /dev/null
+++ b/changes/ticket26069
@@ -0,0 +1,2 @@
+ o Code simplification and refactoring (shell scripts):
+ - Cleanup autogen.sh to silence shellcheck warnings. Closes ticket 26069.