diff options
| author | Nick Mathewson <nickm@torproject.org> | 2013-09-17 17:55:43 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2013-09-20 11:00:27 -0400 |
| commit | 1d0ba9a61f0bc30209a8eae48b863241044b6b23 (patch) | |
| tree | c825e33b880659e488e05c20c687a515e53bb5af | |
| parent | 0c807cf3e48cca5f4f93e8b1082bd62f2978cba4 (diff) | |
| download | tor-1d0ba9a61f0bc30209a8eae48b863241044b6b23.tar.gz tor-1d0ba9a61f0bc30209a8eae48b863241044b6b23.zip | |
Stop sending the current time in client NETINFO handshakes.
Implements part of proposal 222.
| -rw-r--r-- | changes/no_client_timestamps_024 | 5 | ||||
| -rw-r--r-- | src/or/connection_or.c | 5 |
2 files changed, 8 insertions, 2 deletions
diff --git a/changes/no_client_timestamps_024 b/changes/no_client_timestamps_024 new file mode 100644 index 0000000000..6df530743d --- /dev/null +++ b/changes/no_client_timestamps_024 @@ -0,0 +1,5 @@ + o Minor features (security): + - Clients no longer send timestamps in their NETINFO cells. These were + not used for anything, and they provided one small way for clients + to be distinguished from each other as they moved from network to + network or behind NAT. diff --git a/src/or/connection_or.c b/src/or/connection_or.c index d5dd4470e3..95cb39ac89 100644 --- a/src/or/connection_or.c +++ b/src/or/connection_or.c @@ -2051,8 +2051,9 @@ connection_or_send_netinfo(or_connection_t *conn) memset(&cell, 0, sizeof(cell_t)); cell.command = CELL_NETINFO; - /* Timestamp. */ - set_uint32(cell.payload, htonl((uint32_t)now)); + /* Timestamp, if we're a relay. */ + if (! conn->handshake_state->started_here) + set_uint32(cell.payload, htonl((uint32_t)now)); /* Their address. */ out = cell.payload + 4; |