summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexander Færøy <ahf@torproject.org>2021-02-12 15:23:02 +0000
committerAlexander Færøy <ahf@torproject.org>2021-02-12 15:23:02 +0000
commitd24a6b2f75caf7ba6e155d5b21516ce00dd9d30a (patch)
tree1760b2d04f0a8f751060339adb36b1611c3032db
parent088a74aaab84c5598f589fa6d0b6203ca8c666fa (diff)
parent841ee4641ef75e2bb4c7400641ab257e67b6bcce (diff)
downloadtor-d24a6b2f75caf7ba6e155d5b21516ce00dd9d30a.tar.gz
tor-d24a6b2f75caf7ba6e155d5b21516ce00dd9d30a.zip
Merge remote-tracking branch 'tor-gitlab/mr/293' into maint-0.4.5
-rw-r--r--src/feature/relay/router.c10
1 files changed, 7 insertions, 3 deletions
diff --git a/src/feature/relay/router.c b/src/feature/relay/router.c
index 0be3eec1dd..8a7e76e33f 100644
--- a/src/feature/relay/router.c
+++ b/src/feature/relay/router.c
@@ -2678,9 +2678,13 @@ check_descriptor_ipaddress_changed(time_t now)
/* Attempt to discovery the publishable address for the family which will
* actively attempt to discover the address if we are configured with a
- * port for the family. */
- relay_find_addr_to_publish(get_options(), family, RELAY_FIND_ADDR_NO_FLAG,
- &current);
+ * port for the family.
+ *
+ * It is OK to ignore the returned value here since in the failure case,
+ * that is the address was not found, the current value is set to UNSPEC.
+ * Add this (void) so Coverity is happy. */
+ (void) relay_find_addr_to_publish(get_options(), family,
+ RELAY_FIND_ADDR_NO_FLAG, &current);
/* The "current" address might be UNSPEC meaning it was not discovered nor
* found in our current cache. If we had an address before and we have