summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGeorge Kadianakis <desnacked@riseup.net>2017-11-14 17:16:33 +0200
committerGeorge Kadianakis <desnacked@riseup.net>2017-11-14 17:16:33 +0200
commitc4a56ed5c2663ab76460407d6f5a4da8b0f8c600 (patch)
tree0890f310f1c8df5ea4176853ab99897025d12b23
parent6059784be0b022adbe274035acc920381ca3fef0 (diff)
downloadtor-c4a56ed5c2663ab76460407d6f5a4da8b0f8c600.tar.gz
tor-c4a56ed5c2663ab76460407d6f5a4da8b0f8c600.zip
Silence a warning about failed descriptor uploads.
Due to #23662 this can happen under natural causes and does not disturb the functionality of the service. This is a simple 0.3.2 fix for now, and we plan to fix this properly in 0.3.3.
-rw-r--r--changes/bug236624
-rw-r--r--src/or/directory.c9
2 files changed, 9 insertions, 4 deletions
diff --git a/changes/bug23662 b/changes/bug23662
new file mode 100644
index 0000000000..1000bde3d6
--- /dev/null
+++ b/changes/bug23662
@@ -0,0 +1,4 @@
+ o Minor bugfixes (onion services):
+ - Silence a warning about failed v3 onion descriptor uploads since it can
+ happen naturally under certain edge-cases. Fixes part of bug 23662;
+ bugfix on 0.3.2.1-alpha.
diff --git a/src/or/directory.c b/src/or/directory.c
index b2e0a96a2f..836f862988 100644
--- a/src/or/directory.c
+++ b/src/or/directory.c
@@ -3339,10 +3339,11 @@ handle_response_upload_hsdesc(dir_connection_t *conn,
/* XXX: Trigger control event. */
break;
case 400:
- log_warn(LD_REND, "Uploading hidden service descriptor: http "
- "status 400 (%s) response from dirserver "
- "'%s:%d'. Malformed hidden service descriptor?",
- escaped(reason), conn->base_.address, conn->base_.port);
+ log_fn(LOG_PROTOCOL_WARN, LD_REND,
+ "Uploading hidden service descriptor: http "
+ "status 400 (%s) response from dirserver "
+ "'%s:%d'. Malformed hidden service descriptor?",
+ escaped(reason), conn->base_.address, conn->base_.port);
/* XXX: Trigger control event. */
break;
default: