diff options
| author | Nick Mathewson <nickm@torproject.org> | 2020-07-13 09:24:26 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2020-07-13 09:24:26 -0400 |
| commit | 0acc3ae87904ca5d9bd430a5a89f89dd97f9ec85 (patch) | |
| tree | ddcff8e842c44fc4dbe5b2a3c5bc3cb59a692578 | |
| parent | 3517d203227284d41ead62d65e90b38b9f11186e (diff) | |
| download | tor-0acc3ae87904ca5d9bd430a5a89f89dd97f9ec85.tar.gz tor-0acc3ae87904ca5d9bd430a5a89f89dd97f9ec85.zip | |
Remove check-cocci from check-local target.
check-cocci is still a good idea -- perhaps as a cron job? But
doing it as part of our regular tests has just been confusing,
especially to volunteers who shouldn't have to become coccinelle
experts in order to get their patches through our CI.
Closes #40030.
| -rw-r--r-- | Makefile.am | 3 | ||||
| -rw-r--r-- | changes/ticket40030 | 7 |
2 files changed, 8 insertions, 2 deletions
diff --git a/Makefile.am b/Makefile.am index 8b55bf0e32..3b30c01f00 100644 --- a/Makefile.am +++ b/Makefile.am @@ -271,8 +271,7 @@ check-local: \ check-spaces \ check-changes \ check-includes \ - shellcheck \ - check-cocci + shellcheck need-chutney-path: @if test ! -d "$$CHUTNEY_PATH"; then \ diff --git a/changes/ticket40030 b/changes/ticket40030 new file mode 100644 index 0000000000..c5f3ca4ff9 --- /dev/null +++ b/changes/ticket40030 @@ -0,0 +1,7 @@ + o Removed features: + - Our "check-local" test target no longer tries to use the Coccinelle + semantic patching tool parse all the C files. While it is a good idea + to try to make sure Coccinelle works on our C before we run a + Coccinelle patch, doing so on every test run has proven to be disruptive. + You can still run this tool manually with "make check-cocci". Closes + ticket 40030. |