summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Goulet <dgoulet@torproject.org>2020-03-26 09:15:00 -0400
committerDavid Goulet <dgoulet@torproject.org>2020-03-26 09:15:00 -0400
commit78ac7c751cf3051efe26f6c1e5fc7234bafe3942 (patch)
tree123ec85a5aedc391f429d11f725f260fc9a3a33b
parent0c7725be847b0286a942c9f118e59291efeb8398 (diff)
parente472737297f5924a584fc8f434aba085e89b887a (diff)
downloadtor-78ac7c751cf3051efe26f6c1e5fc7234bafe3942.tar.gz
tor-78ac7c751cf3051efe26f6c1e5fc7234bafe3942.zip
Merge branch 'maint-0.4.3' into release-0.4.3
-rw-r--r--changes/bug336085
-rw-r--r--src/core/mainloop/connection.c3
2 files changed, 7 insertions, 1 deletions
diff --git a/changes/bug33608 b/changes/bug33608
new file mode 100644
index 0000000000..0e82a8eec9
--- /dev/null
+++ b/changes/bug33608
@@ -0,0 +1,5 @@
+ o Minor bugfixes (client IPv6):
+ - Stop forcing all non-SOCKSPorts to prefer IPv6 exit connections. Instead,
+ prefer IPv6 connections by default, but allow users to change their
+ configs using the "NoPreferIPv6" port flag.
+ Fixes bug 33608; bugfix on 0.4.3.1-alpha.
diff --git a/src/core/mainloop/connection.c b/src/core/mainloop/connection.c
index bfd850da86..57b48d49f3 100644
--- a/src/core/mainloop/connection.c
+++ b/src/core/mainloop/connection.c
@@ -1514,10 +1514,11 @@ connection_listener_new(const struct sockaddr *listensockaddr,
}
}
+ /* Force IPv4 and IPv6 traffic on for non-SOCKSPorts.
+ * Forcing options on isn't a good idea, see #32994 and #33607. */
if (type != CONN_TYPE_AP_LISTENER) {
lis_conn->entry_cfg.ipv4_traffic = 1;
lis_conn->entry_cfg.ipv6_traffic = 1;
- lis_conn->entry_cfg.prefer_ipv6 = 1;
}
if (connection_add(conn) < 0) { /* no space, forget it */