summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2020-02-05 19:18:32 -0500
committerNick Mathewson <nickm@torproject.org>2020-02-05 19:18:32 -0500
commit56c54a66bdc01a9e8b857f22650ca88d8eff5466 (patch)
treec52bf226e02f8608f6d095758e61136bfe54dac7
parent2c4d7d8c65b3783fa9213cc632d398d0d1b6ef5c (diff)
downloadtor-56c54a66bdc01a9e8b857f22650ca88d8eff5466.tar.gz
tor-56c54a66bdc01a9e8b857f22650ca88d8eff5466.zip
Fix a memory leak in handling GETINFO.
Fixes bug 33103; bugfix on 0.4.3.1-alpha.
-rw-r--r--changes/ticket331033
-rw-r--r--src/feature/control/control_getinfo.c1
2 files changed, 4 insertions, 0 deletions
diff --git a/changes/ticket33103 b/changes/ticket33103
new file mode 100644
index 0000000000..889805f103
--- /dev/null
+++ b/changes/ticket33103
@@ -0,0 +1,3 @@
+ o Minor bugfixes (controller):
+ - Fix a memory leak in GETINFO responses. Fixes bug 33103;
+ bugfix on 0.4.3.1-alpha.
diff --git a/src/feature/control/control_getinfo.c b/src/feature/control/control_getinfo.c
index 6f30878d23..5dcc4b170d 100644
--- a/src/feature/control/control_getinfo.c
+++ b/src/feature/control/control_getinfo.c
@@ -1735,6 +1735,7 @@ handle_control_getinfo(control_connection_t *conn,
}
} else {
control_reply_add_one_kv(answers, 250, KV_RAW, q, ans);
+ tor_free(ans);
}
} SMARTLIST_FOREACH_END(q);