diff options
| author | Nick Mathewson <nickm@torproject.org> | 2019-12-16 15:14:13 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2019-12-16 15:14:13 -0500 |
| commit | 1b619a627ca1ee11d1680dc56e90e9fc1af2ddb5 (patch) | |
| tree | 39e9f8d2a560277f05e0a6c3845e28e44f11f160 | |
| parent | ffccf6fc55f691e01ccd3e756486415cbc7ffe8a (diff) | |
| download | tor-1b619a627ca1ee11d1680dc56e90e9fc1af2ddb5.tar.gz tor-1b619a627ca1ee11d1680dc56e90e9fc1af2ddb5.zip | |
Use CHECK_PRINTF() for printf-like functions in util_bug.h
| -rw-r--r-- | changes/ticket32765 | 4 | ||||
| -rw-r--r-- | src/lib/log/util_bug.h | 6 |
2 files changed, 8 insertions, 2 deletions
diff --git a/changes/ticket32765 b/changes/ticket32765 new file mode 100644 index 0000000000..a9663a5df3 --- /dev/null +++ b/changes/ticket32765 @@ -0,0 +1,4 @@ + o Minor bugfixes (correctness checks): + - Use GCC/Clang's printf-checking feature to make sure that + tor_assertf() arguments are correctly typed. Fixes bug 32765; + bugfix on 0.4.1.1-alpha. diff --git a/src/lib/log/util_bug.h b/src/lib/log/util_bug.h index 546ae1e3ef..993a4e3abd 100644 --- a/src/lib/log/util_bug.h +++ b/src/lib/log/util_bug.h @@ -242,10 +242,12 @@ void tor_assertion_failed_(const char *fname, unsigned int line, const char *func, const char *expr, - const char *fmt, ...); + const char *fmt, ...) + CHECK_PRINTF(5,6); void tor_bug_occurred_(const char *fname, unsigned int line, const char *func, const char *expr, - int once, const char *fmt, ...); + int once, const char *fmt, ...) + CHECK_PRINTF(6,7); void tor_abort_(void) ATTR_NORETURN; |