diff options
| author | David Goulet <dgoulet@torproject.org> | 2019-10-02 10:37:49 -0400 |
|---|---|---|
| committer | David Goulet <dgoulet@torproject.org> | 2019-10-02 10:37:49 -0400 |
| commit | 014abf86e5a6484d23f72bb6959d78e379d90206 (patch) | |
| tree | 921f18a7098c35859035feb39386d5383b40f729 | |
| parent | 40be20d542a83359ea480bbaa28380b4137c88b2 (diff) | |
| parent | 37c616aeaf21fc54a367361272e5f1fc84d4a508 (diff) | |
| download | tor-014abf86e5a6484d23f72bb6959d78e379d90206.tar.gz tor-014abf86e5a6484d23f72bb6959d78e379d90206.zip | |
Merge branch 'tor-github/pr/1344'
| -rw-r--r-- | changes/ticket31466 | 5 | ||||
| -rw-r--r-- | src/core/or/connection_edge.c | 6 |
2 files changed, 9 insertions, 2 deletions
diff --git a/changes/ticket31466 b/changes/ticket31466 new file mode 100644 index 0000000000..e535b4502e --- /dev/null +++ b/changes/ticket31466 @@ -0,0 +1,5 @@ + o Minor bugfixes (logging): + - Rate-limit our the logging message about the obsolete .exit notation. + Previously, there was no limit on this warning, which could potentially + be triggered many times by a hostile website. Fixes bug 31466; + bugfix on 0.2.2.1-alpha. diff --git a/src/core/or/connection_edge.c b/src/core/or/connection_edge.c index 3122a190dd..5f1664d286 100644 --- a/src/core/or/connection_edge.c +++ b/src/core/or/connection_edge.c @@ -1611,8 +1611,10 @@ connection_ap_handshake_rewrite(entry_connection_t *conn, * disallowed when they're coming straight from the client, but you're * allowed to have them in MapAddress commands and so forth. */ if (!strcmpend(socks->address, ".exit")) { - log_warn(LD_APP, "The \".exit\" notation is disabled in Tor due to " - "security risks."); + static ratelim_t exit_warning_limit = RATELIM_INIT(60*15); + log_fn_ratelim(&exit_warning_limit, LOG_WARN, LD_APP, + "The \".exit\" notation is disabled in Tor due to " + "security risks."); control_event_client_status(LOG_WARN, "SOCKS_BAD_HOSTNAME HOSTNAME=%s", escaped(socks->address)); out->end_reason = END_STREAM_REASON_TORPROTOCOL; |