summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2019-04-29 13:48:25 -0400
committerNick Mathewson <nickm@torproject.org>2019-04-29 14:34:03 -0400
commit821dd54586bffd95bdd8c9d333b1f80ef55d3742 (patch)
treeccabe51b9601cc9e8ce28b411656915aa83009f4
parent593d29920e264180a7a6849fc59224a8869388d7 (diff)
parent0ab4dc7ef7c6468c1d0d87a7cbc834217214f16b (diff)
downloadtor-821dd54586bffd95bdd8c9d333b1f80ef55d3742.tar.gz
tor-821dd54586bffd95bdd8c9d333b1f80ef55d3742.zip
Merge branch 'bug30316_035' into bug30316_040
Fixes conflicts and also moves bandwidth-file-digest.
-rw-r--r--changes/bug303164
-rw-r--r--src/feature/dirauth/dirvote.c11
2 files changed, 9 insertions, 6 deletions
diff --git a/changes/bug30316 b/changes/bug30316
new file mode 100644
index 0000000000..3e396318ad
--- /dev/null
+++ b/changes/bug30316
@@ -0,0 +1,4 @@
+ o Minor bugfixes (directory authority):
+ - Move the "bandwidth-file-headers" line in directory authority votes
+ so that it conforms to dir-spec.txt. Fixes bug 30316; bugfix on
+ 0.3.5.1-alpha.
diff --git a/src/feature/dirauth/dirvote.c b/src/feature/dirauth/dirvote.c
index 29f5d04509..755b99bae2 100644
--- a/src/feature/dirauth/dirvote.c
+++ b/src/feature/dirauth/dirvote.c
@@ -348,11 +348,11 @@ format_networkstatus_vote(crypto_pk_t *private_signing_key,
"known-flags %s\n"
"flag-thresholds %s\n"
"params %s\n"
+ "%s" /* bandwidth file headers */
+ "%s" /* bandwidth file digest */
"dir-source %s %s %s %s %d %d\n"
"contact %s\n"
"%s" /* shared randomness information */
- "%s" /* bandwidth file headers */
- "%s" /* bandwidth file */
,
v3_ns->type == NS_TYPE_VOTE ? "vote" : "opinion",
methods,
@@ -365,14 +365,13 @@ format_networkstatus_vote(crypto_pk_t *private_signing_key,
flags,
flag_thresholds,
params,
+ bw_headers_line ? bw_headers_line : "",
+ bw_file_digest ? bw_file_digest: "",
voter->nickname, fingerprint, voter->address,
fmt_addr32(addr), voter->dir_port, voter->or_port,
voter->contact,
shared_random_vote_str ?
- shared_random_vote_str : "",
- bw_headers_line ?
- bw_headers_line : "",
- bw_file_digest ? bw_file_digest: "");
+ shared_random_vote_str : "");
tor_free(params);
tor_free(flags);