diff options
| author | Nick Mathewson <nickm@torproject.org> | 2019-06-05 16:22:52 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2019-06-05 16:22:52 -0400 |
| commit | 6a6f7eb6718f22da80596a35e7774b075a417e97 (patch) | |
| tree | 85b5b98638fbed4fcb1e5da724a55db600f17117 | |
| parent | d63c17f2afb810f5db896b10909fe9ff2bfe7cf9 (diff) | |
| parent | 821dd54586bffd95bdd8c9d333b1f80ef55d3742 (diff) | |
| download | tor-6a6f7eb6718f22da80596a35e7774b075a417e97.tar.gz tor-6a6f7eb6718f22da80596a35e7774b075a417e97.zip | |
Merge remote-tracking branch 'tor-github/pr/988' into maint-0.4.0
| -rw-r--r-- | changes/bug30316 | 4 | ||||
| -rw-r--r-- | src/feature/dirauth/dirvote.c | 11 |
2 files changed, 9 insertions, 6 deletions
diff --git a/changes/bug30316 b/changes/bug30316 new file mode 100644 index 0000000000..3e396318ad --- /dev/null +++ b/changes/bug30316 @@ -0,0 +1,4 @@ + o Minor bugfixes (directory authority): + - Move the "bandwidth-file-headers" line in directory authority votes + so that it conforms to dir-spec.txt. Fixes bug 30316; bugfix on + 0.3.5.1-alpha. diff --git a/src/feature/dirauth/dirvote.c b/src/feature/dirauth/dirvote.c index 29f5d04509..755b99bae2 100644 --- a/src/feature/dirauth/dirvote.c +++ b/src/feature/dirauth/dirvote.c @@ -348,11 +348,11 @@ format_networkstatus_vote(crypto_pk_t *private_signing_key, "known-flags %s\n" "flag-thresholds %s\n" "params %s\n" + "%s" /* bandwidth file headers */ + "%s" /* bandwidth file digest */ "dir-source %s %s %s %s %d %d\n" "contact %s\n" "%s" /* shared randomness information */ - "%s" /* bandwidth file headers */ - "%s" /* bandwidth file */ , v3_ns->type == NS_TYPE_VOTE ? "vote" : "opinion", methods, @@ -365,14 +365,13 @@ format_networkstatus_vote(crypto_pk_t *private_signing_key, flags, flag_thresholds, params, + bw_headers_line ? bw_headers_line : "", + bw_file_digest ? bw_file_digest: "", voter->nickname, fingerprint, voter->address, fmt_addr32(addr), voter->dir_port, voter->or_port, voter->contact, shared_random_vote_str ? - shared_random_vote_str : "", - bw_headers_line ? - bw_headers_line : "", - bw_file_digest ? bw_file_digest: ""); + shared_random_vote_str : ""); tor_free(params); tor_free(flags); |