summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2019-01-18 12:25:08 -0500
committerNick Mathewson <nickm@torproject.org>2019-01-18 12:25:08 -0500
commitd1af4d65df8b5ef8049707029335049db147829f (patch)
tree1517eef46bed94b18388303176d5113ead1bce9d
parent9d7b4f1ca8c8e096c56e963fa34eec480f22fa03 (diff)
parenta8580a683696eb76f5f24fe36e7ea61f9c49db0a (diff)
downloadtor-d1af4d65df8b5ef8049707029335049db147829f.tar.gz
tor-d1af4d65df8b5ef8049707029335049db147829f.zip
Merge branch 'maint-0.3.5'
-rw-r--r--changes/bug290295
-rw-r--r--src/feature/rend/rendmid.c6
2 files changed, 8 insertions, 3 deletions
diff --git a/changes/bug29029 b/changes/bug29029
new file mode 100644
index 0000000000..e100a8c2ed
--- /dev/null
+++ b/changes/bug29029
@@ -0,0 +1,5 @@
+ o Minor bugfixes (logging, onion services):
+ - Stop logging "Tried to establish rendezvous on non-OR circuit..." as
+ a warning. Instead, log it as a protocol warning, because there is
+ nothing that relay operators can do to fix it. Fixes bug 29029;
+ bugfix on 0.2.5.7-rc.
diff --git a/src/feature/rend/rendmid.c b/src/feature/rend/rendmid.c
index 7c96f23629..849f355990 100644
--- a/src/feature/rend/rendmid.c
+++ b/src/feature/rend/rendmid.c
@@ -230,9 +230,9 @@ rend_mid_establish_rendezvous(or_circuit_t *circ, const uint8_t *request,
(unsigned)circ->p_circ_id);
if (circ->base_.purpose != CIRCUIT_PURPOSE_OR) {
- log_warn(LD_PROTOCOL,
- "Tried to establish rendezvous on non-OR circuit with purpose %s",
- circuit_purpose_to_string(circ->base_.purpose));
+ log_fn(LOG_PROTOCOL_WARN, LD_PROTOCOL,
+ "Tried to establish rendezvous on non-OR circuit with purpose %s",
+ circuit_purpose_to_string(circ->base_.purpose));
goto err;
}