summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorrl1987 <rl1987@sdf.lonestar.org>2019-01-21 12:06:46 +0200
committerDavid Goulet <dgoulet@torproject.org>2019-01-23 10:37:10 -0500
commit712a622fcecd43a7a50c7b35a9811f1210aeadb8 (patch)
treee4bf88dad1956a631e987bd23fd51cd70f098a62
parentf9050681c032bd339bdf6314c9ee8e577d37cedc (diff)
downloadtor-712a622fcecd43a7a50c7b35a9811f1210aeadb8.tar.gz
tor-712a622fcecd43a7a50c7b35a9811f1210aeadb8.zip
Log an HSDesc we failed to parse at Debug loglevel
-rw-r--r--changes/bug291355
-rw-r--r--src/feature/hs/hs_cache.c4
2 files changed, 7 insertions, 2 deletions
diff --git a/changes/bug29135 b/changes/bug29135
new file mode 100644
index 0000000000..fd7b1ae80e
--- /dev/null
+++ b/changes/bug29135
@@ -0,0 +1,5 @@
+ o Minor bugfixes (onion services, logging):
+ - In hs_cache_store_as_client() log an HSDesc we failed to parse at Debug
+ loglevel. Tor used to log it at Warning loglevel, which caused
+ very long log lines to appear for some users. Fixes bug 29135; bugfix on
+ 0.3.2.1-alpha.
diff --git a/src/feature/hs/hs_cache.c b/src/feature/hs/hs_cache.c
index 82ce686424..05f9940ae6 100644
--- a/src/feature/hs/hs_cache.c
+++ b/src/feature/hs/hs_cache.c
@@ -778,8 +778,8 @@ hs_cache_store_as_client(const char *desc_str,
/* Create client cache descriptor object */
client_desc = cache_client_desc_new(desc_str, identity_pk);
if (!client_desc) {
- log_warn(LD_GENERAL, "Failed to parse received descriptor %s.",
- escaped(desc_str));
+ log_warn(LD_GENERAL, "HSDesc parsing failed!");
+ log_debug(LD_GENERAL, "Failed to parse HSDesc: %s.", escaped(desc_str));
goto err;
}