diff options
| author | Nick Mathewson <nickm@torproject.org> | 2018-09-14 12:56:31 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2018-09-14 12:56:31 -0400 |
| commit | 4bdba5fa4b42a22936c5b10146a8838e13135b51 (patch) | |
| tree | 627a931072de4d442a421dff5989626ead9743ae | |
| parent | 6e940829cce9e822f7fbd07e260a62a195a94143 (diff) | |
| parent | 6f47734ea8dde2d05160644dfcfcd34ee1a63505 (diff) | |
| download | tor-4bdba5fa4b42a22936c5b10146a8838e13135b51.tar.gz tor-4bdba5fa4b42a22936c5b10146a8838e13135b51.zip | |
Merge branch 'maint-0.3.4'
| -rw-r--r-- | changes/bug27335 | 4 | ||||
| -rw-r--r-- | src/feature/hs/hs_service.c | 6 |
2 files changed, 7 insertions, 3 deletions
diff --git a/changes/bug27335 b/changes/bug27335 new file mode 100644 index 0000000000..dcc55a945a --- /dev/null +++ b/changes/bug27335 @@ -0,0 +1,4 @@ + o Minor bugfixes (hidden service v3): + - In case the hidden service directory can't be created or has wrong + permissions, do not BUG() on it which lead to a non fatal stacktrace. + Fixes bug 27335; bugfix on 0.3.2.1. diff --git a/src/feature/hs/hs_service.c b/src/feature/hs/hs_service.c index b01f9f0adf..243ecb9b52 100644 --- a/src/feature/hs/hs_service.c +++ b/src/feature/hs/hs_service.c @@ -1040,9 +1040,9 @@ load_service_keys(hs_service_t *service) * files to that directory so make sure it exists and has the right * permissions. We do this here because at this stage we know that Tor is * actually running and the service we have has been validated. */ - if (BUG(hs_check_service_private_dir(get_options()->User, - config->directory_path, - config->dir_group_readable, 1) < 0)) { + if (hs_check_service_private_dir(get_options()->User, + config->directory_path, + config->dir_group_readable, 1) < 0) { goto end; } |