summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2018-09-07 08:46:45 -0400
committerNick Mathewson <nickm@torproject.org>2018-09-07 08:46:45 -0400
commitb36f128cee5520ac37acafa0459c9bf14dedad5a (patch)
treeaf0e487ad00774375831a09fe08eb4702d6db232
parent17511b0dca8d2ef7e579b529c47f07a00b1b2d74 (diff)
parenta78504dbe62efac4a8f0ce03f3fb1123bde7c1dd (diff)
downloadtor-b36f128cee5520ac37acafa0459c9bf14dedad5a.tar.gz
tor-b36f128cee5520ac37acafa0459c9bf14dedad5a.zip
Merge branch 'maint-0.3.4' into release-0.3.4
-rw-r--r--changes/bug274615
-rw-r--r--src/or/main.c8
2 files changed, 13 insertions, 0 deletions
diff --git a/changes/bug27461 b/changes/bug27461
new file mode 100644
index 0000000000..3571ee816a
--- /dev/null
+++ b/changes/bug27461
@@ -0,0 +1,5 @@
+ o Minor bugfixes (compilation):
+ - Stop calling SetProcessDEPPolicy() on 64-bit Windows. It is not
+ supported, and always fails. Some compilers warn about the function
+ pointer cast on 64-bit Windows.
+ Fixes bug 27461; bugfix on 0.2.2.23-alpha.
diff --git a/src/or/main.c b/src/or/main.c
index 0c7f3a5be4..a93fdc3922 100644
--- a/src/or/main.c
+++ b/src/or/main.c
@@ -4206,6 +4206,13 @@ tor_run_main(const tor_main_configuration_t *tor_cfg)
#endif
/* On heap corruption, just give up; don't try to play along. */
HeapSetInformation(NULL, HeapEnableTerminationOnCorruption, NULL, 0);
+
+ /* SetProcessDEPPolicy is only supported on 32-bit Windows.
+ * (On 64-bit Windows it always fails, and some compilers don't like the
+ * PSETDEP cast.)
+ * 32-bit Windows defines _WIN32.
+ * 64-bit Windows defines _WIN32 and _WIN64. */
+#ifndef _WIN64
/* Call SetProcessDEPPolicy to permanently enable DEP.
The function will not resolve on earlier versions of Windows,
and failure is not dangerous. */
@@ -4219,6 +4226,7 @@ tor_run_main(const tor_main_configuration_t *tor_cfg)
setdeppolicy(3);
}
}
+#endif /* !defined(_WIN64) */
#endif /* defined(_WIN32) */
configure_backtrace_handler(get_version());