summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2016-06-11 10:16:00 -0400
committerNick Mathewson <nickm@torproject.org>2016-06-11 10:16:00 -0400
commitada5668c5e2c32e7419091221627bff8b4d254fe (patch)
tree6b2025bd1b8c616cadb408b6f37294a57fc4cc77
parent6eeedc02d8aee0bf1eda8e592764ec9c5df4add7 (diff)
parentbdc59e33c13672b64d5d52dfc395f9e80c6ed528 (diff)
downloadtor-ada5668c5e2c32e7419091221627bff8b4d254fe.tar.gz
tor-ada5668c5e2c32e7419091221627bff8b4d254fe.zip
Merge remote-tracking branch 'public/bug19203_027' into maint-0.2.8
-rw-r--r--changes/bug192034
-rw-r--r--src/or/nodelist.c4
2 files changed, 6 insertions, 2 deletions
diff --git a/changes/bug19203 b/changes/bug19203
new file mode 100644
index 0000000000..96bc1e855a
--- /dev/null
+++ b/changes/bug19203
@@ -0,0 +1,4 @@
+ o Major bugfixes (user interface):
+ - Correctly give a warning in the cases where a relay is specified by
+ nickname, and one such relay is found, but it is not officially Named.
+ Fixes bug 19203; bugfix on 0.2.3.1-alpha.
diff --git a/src/or/nodelist.c b/src/or/nodelist.c
index abbb82dfdd..89b5355c8d 100644
--- a/src/or/nodelist.c
+++ b/src/or/nodelist.c
@@ -594,10 +594,10 @@ node_get_by_nickname,(const char *nickname, int warn_if_unnamed))
"but none is listed as Named in the directory consensus. "
"Choosing one arbitrarily.", nickname);
}
- } else if (smartlist_len(matches)>1 && warn_if_unnamed) {
+ } else if (smartlist_len(matches)==1 && warn_if_unnamed) {
char fp[HEX_DIGEST_LEN+1];
node_t *node = smartlist_get(matches, 0);
- if (node->name_lookup_warned) {
+ if (! node->name_lookup_warned) {
base16_encode(fp, sizeof(fp), node->identity, DIGEST_LEN);
log_warn(LD_CONFIG,
"You specified a server \"%s\" by name, but the directory "