summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2018-03-23 11:31:56 -0400
committerNick Mathewson <nickm@torproject.org>2018-07-09 09:20:45 -0400
commita95cfb8a58cc17c217750b1c39cb5b1237e38aea (patch)
tree2e388b8e6c61d2066dab18382cc43a91973480d6
parentf721a08220fc0bef4e029e3fb87b9160782527c0 (diff)
downloadtor-a95cfb8a58cc17c217750b1c39cb5b1237e38aea.tar.gz
tor-a95cfb8a58cc17c217750b1c39cb5b1237e38aea.zip
Clear all control.c flags on control_free_all()
Fixes bug 25512. (Cherry-picked from 3519d0c8086ede
-rw-r--r--changes/bug255125
-rw-r--r--src/or/control.c9
2 files changed, 13 insertions, 1 deletions
diff --git a/changes/bug25512 b/changes/bug25512
new file mode 100644
index 0000000000..4b6491867e
--- /dev/null
+++ b/changes/bug25512
@@ -0,0 +1,5 @@
+ o Minor bugfixes (restart-in-process):
+ - When shutting down, Tor now clears all the flags in the control.c
+ module. This should prevent a bug where authentication cookies
+ are not generated on restart. Fixes bug 25512; bugfix on 0.3.3.1-alpha.
+
diff --git a/src/or/control.c b/src/or/control.c
index 06360586ee..1898725025 100644
--- a/src/or/control.c
+++ b/src/or/control.c
@@ -7610,6 +7610,14 @@ control_free_all(void)
tor_event_free(flush_queued_events_event);
flush_queued_events_event = NULL;
}
+ bootstrap_percent = BOOTSTRAP_STATUS_UNDEF;
+ notice_bootstrap_percent = 0;
+ bootstrap_problems = 0;
+ authentication_cookie_is_set = 0;
+ global_event_mask = 0;
+ disable_log_messages = 0;
+ memset(last_sent_bootstrap_message, 0, sizeof(last_sent_bootstrap_message));
+ flush_queued_event_pending = 0;
}
#ifdef TOR_UNIT_TESTS
@@ -7620,4 +7628,3 @@ control_testing_set_global_event_mask(uint64_t mask)
global_event_mask = mask;
}
#endif /* defined(TOR_UNIT_TESTS) */
-