diff options
| author | Steven Murdoch <Steven.Murdoch@cl.cam.ac.uk> | 2010-10-04 14:19:17 +0100 |
|---|---|---|
| committer | Steven Murdoch <Steven.Murdoch@cl.cam.ac.uk> | 2010-10-10 19:07:40 +0100 |
| commit | 708ba8899f21a03564d96eccc202c3c7a37994bb (patch) | |
| tree | fb47c53af80ccf7bb24765dedba3e534df11edba | |
| parent | 5a77c648345fe0f7750c58e4d6aee96eff3e02fe (diff) | |
| download | tor-708ba8899f21a03564d96eccc202c3c7a37994bb.tar.gz tor-708ba8899f21a03564d96eccc202c3c7a37994bb.zip | |
Note icky constructs mentioned in bug #1903
- To be dealt with as part of bug #2029
| -rw-r--r-- | src/common/util.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/common/util.c b/src/common/util.c index 6c7794d1e6..afd9d2e020 100644 --- a/src/common/util.c +++ b/src/common/util.c @@ -3061,7 +3061,8 @@ tor_spawn_background(const char *const filename, int *stdout_read, child_state = CHILD_STATE_CLOSEFD; /* Close all other fds, including the read end of the pipe */ - /* TODO: use closefrom if available */ + /* XXX: use closefrom if available, or better still set FD_CLOEXEC + on all of Tor's open files */ for (fd = STDERR_FILENO + 1; fd < max_fd; fd++) close(fd); @@ -3077,7 +3078,7 @@ tor_spawn_background(const char *const filename, int *stdout_read, child_state = CHILD_STATE_FAILEXEC; error: - /* TODO: are we leaking fds from the pipe? */ + /* XXX: are we leaking fds from the pipe? */ format_helper_exit_status(child_state, errno, hex_errno); |