diff options
| author | Nick Mathewson <nickm@torproject.org> | 2013-04-24 22:04:15 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2013-04-24 22:04:15 -0400 |
| commit | cab5f82d125d721fa4b73568323ac1b6009002c3 (patch) | |
| tree | 53718c61c08693fb25a7a89b490cdd88b69addea | |
| parent | b933360ee848873db6c051eabe5aecd01b3f67a3 (diff) | |
| parent | ac22bf27d73c51ce6da5afbd2ec29a5403eea2d1 (diff) | |
| download | tor-cab5f82d125d721fa4b73568323ac1b6009002c3.tar.gz tor-cab5f82d125d721fa4b73568323ac1b6009002c3.zip | |
Merge branch 'bug8235-fix-rebased' into maint-0.2.4
| -rw-r--r-- | changes/bug8253-fix | 6 | ||||
| -rw-r--r-- | src/or/circuitbuild.c | 4 | ||||
| -rw-r--r-- | src/or/entrynodes.c | 4 |
3 files changed, 10 insertions, 4 deletions
diff --git a/changes/bug8253-fix b/changes/bug8253-fix new file mode 100644 index 0000000000..3d36d06c88 --- /dev/null +++ b/changes/bug8253-fix @@ -0,0 +1,6 @@ + o Minor bugfixes (log messages) + - Fix a scaling issue in the path bias accounting code that resulted in + "Bug:" log messages from either pathbias_scale_close_rates() or + pathbias_count_build_success(). This represents a bugfix on a previous + bugfix: The original fix attempted in 0.2.4.10-alpha was incomplete. + Fixes bug 8235; bugfix on 0.2.4.1-alpha. diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 31242f6c14..43d2ffe4db 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -2491,7 +2491,7 @@ pathbias_scale_close_rates(entry_guard_t *guard) /* Verify that the counts are sane before and after scaling */ int counts_are_sane = (guard->circ_attempts >= guard->circ_successes); - guard->circ_attempts -= opened_attempts; + guard->circ_attempts -= (opened_attempts+opened_built); guard->circ_successes -= opened_built; guard->circ_attempts *= scale_ratio; @@ -2501,7 +2501,7 @@ pathbias_scale_close_rates(entry_guard_t *guard) guard->collapsed_circuits *= scale_ratio; guard->unusable_circuits *= scale_ratio; - guard->circ_attempts += opened_attempts; + guard->circ_attempts += (opened_attempts+opened_built); guard->circ_successes += opened_built; entry_guards_changed(); diff --git a/src/or/entrynodes.c b/src/or/entrynodes.c index 3234f4f3c7..7a1f67d16a 100644 --- a/src/or/entrynodes.c +++ b/src/or/entrynodes.c @@ -1215,7 +1215,7 @@ entry_guards_parse_state(or_state_t *state, int set, char **msg) int severity = LOG_INFO; /* If this state file was written by a Tor that would have * already fixed it, then the overcounting bug is still there.. */ - if (tor_version_as_new_as(state_version, "0.2.4.12-alpha")) { + if (tor_version_as_new_as(state_version, "0.2.4.13-alpha")) { severity = LOG_NOTICE; } log_fn(severity, LD_BUG, @@ -1280,7 +1280,7 @@ entry_guards_parse_state(or_state_t *state, int set, char **msg) int severity = LOG_INFO; /* If this state file was written by a Tor that would have * already fixed it, then the overcounting bug is still there.. */ - if (tor_version_as_new_as(state_version, "0.2.4.12-alpha")) { + if (tor_version_as_new_as(state_version, "0.2.4.13-alpha")) { severity = LOG_NOTICE; } log_fn(severity, LD_BUG, |