summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTaylor Yu <catalyst@torproject.org>2017-10-02 16:09:28 -0500
committerTaylor Yu <catalyst@torproject.org>2017-10-02 16:09:28 -0500
commite31ffb274132662e2ce13439a52554022154773c (patch)
tree76ed4977b552b21d17d75bf17a2577979973c7af
parentdddae36f5e0e9e088cd9aa98c6e4a6c904e1efa4 (diff)
downloadtor-e31ffb274132662e2ce13439a52554022154773c.tar.gz
tor-e31ffb274132662e2ce13439a52554022154773c.zip
Don't move gcov output to root directory
In scripts/test/coverage, avoid attempting to move gcov output files to the root directory when given no arguments. Fixes bug 23741.
-rw-r--r--changes/bug237414
-rwxr-xr-xscripts/test/coverage2
2 files changed, 5 insertions, 1 deletions
diff --git a/changes/bug23741 b/changes/bug23741
new file mode 100644
index 0000000000..92f06f5270
--- /dev/null
+++ b/changes/bug23741
@@ -0,0 +1,4 @@
+ o Minor bugfixes (testing):
+ - Prevent scripts/test/coverage from attempting to move gcov
+ output to the root directory. Fixes bug 23741; bugfix on
+ 0.2.5.1-alpha.
diff --git a/scripts/test/coverage b/scripts/test/coverage
index f4ae475828..f10c5afaae 100755
--- a/scripts/test/coverage
+++ b/scripts/test/coverage
@@ -29,7 +29,7 @@ for fn in src/or/*.c src/common/*.c; do
gcov -o $on $fn
if [ -e $GC ]
then
- if [ -n $dst ]
+ if [ -d "$dst" ]
then
mv $GC $dst/$GC
fi