summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2017-07-27 16:11:58 -0400
committerNick Mathewson <nickm@torproject.org>2017-07-27 16:28:59 -0400
commitf5a852de91110c4db367946e848656b45a078f39 (patch)
tree33502f62eb6169d894b10334dc3ef90326556b44
parent250c88014d81fcd4406359d44c9f3f3432844a2f (diff)
downloadtor-f5a852de91110c4db367946e848656b45a078f39.tar.gz
tor-f5a852de91110c4db367946e848656b45a078f39.zip
Note that threadpool_queue_work...() can't actually return NULL
-rw-r--r--src/common/workqueue.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/common/workqueue.c b/src/common/workqueue.c
index f44f566d21..d1303ee0e3 100644
--- a/src/common/workqueue.c
+++ b/src/common/workqueue.c
@@ -360,7 +360,8 @@ workerthread_new(int32_t lower_priority_chance,
* function's responsibility to free the work object.
*
* On success, return a workqueue_entry_t object that can be passed to
- * workqueue_entry_cancel(). On failure, return NULL.
+ * workqueue_entry_cancel(). On failure, return NULL. (Failure is not
+ * currently possible, but callers should check anyway.)
*
* Items are executed in a loose priority order -- each thread will usually
* take from the queued work with the highest prioirity, but will occasionally