summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRoger Dingledine <arma@torproject.org>2017-05-21 02:05:32 -0400
committerNick Mathewson <nickm@torproject.org>2017-05-22 08:31:39 -0400
commit6e5486b11ac113ab7cf42d167dd5555b5916ddbc (patch)
treefc2e859b40f3d19b277261b51cc947180bd6f9a4
parenta7bcab263959887b27500372bc6fa1fa0f8c947b (diff)
downloadtor-6e5486b11ac113ab7cf42d167dd5555b5916ddbc.tar.gz
tor-6e5486b11ac113ab7cf42d167dd5555b5916ddbc.zip
dir auths reject 0.2.9.x for x<5, due to bug 20499
Directory authorities now reject relays running versions 0.2.9.1-alpha through 0.2.9.4-alpha, because those relays suffer from bug 20499 and don't keep their consensus cache up-to-date. Resolves ticket 20509.
-rw-r--r--changes/bug205095
-rw-r--r--src/or/dirserv.c11
2 files changed, 16 insertions, 0 deletions
diff --git a/changes/bug20509 b/changes/bug20509
new file mode 100644
index 0000000000..a39ca9f60b
--- /dev/null
+++ b/changes/bug20509
@@ -0,0 +1,5 @@
+ o Minor features:
+ - Directory authorities now reject relays running versions
+ 0.2.9.1-alpha through 0.2.9.4-alpha, because those relays
+ suffer from bug 20499 and don't keep their consensus cache
+ up-to-date. Resolves ticket 20509.
diff --git a/src/or/dirserv.c b/src/or/dirserv.c
index fa3938b5ec..fedbe51b4c 100644
--- a/src/or/dirserv.c
+++ b/src/or/dirserv.c
@@ -383,6 +383,17 @@ dirserv_get_status_impl(const char *id_digest, const char *nickname,
return FP_REJECT;
}
+ /* Tor 0.2.9.x where x<5 suffers from bug #20499, where relays don't
+ * keep their consensus up to date so they make bad guards.
+ * The simple fix is to just drop them from the network. */
+ if (platform &&
+ tor_version_as_new_as(platform,"0.2.9.0-alpha") &&
+ !tor_version_as_new_as(platform,"0.2.9.5-alpha")) {
+ if (msg)
+ *msg = "Tor version contains bug 20499. Please upgrade!";
+ return FP_REJECT;
+ }
+
status_by_digest = digestmap_get(fingerprint_list->status_by_digest,
id_digest);
if (status_by_digest)