diff options
| author | Nick Mathewson <nickm@torproject.org> | 2016-11-29 11:34:37 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2016-12-16 11:06:19 -0500 |
| commit | 46619ec9143450b181a8510011d3e3fd92542aa4 (patch) | |
| tree | 97d2d40a26c9228ab88ce61814075872e57be882 | |
| parent | 3bcbbea350ccab4bc25b191fcce1dd3fc63775d3 (diff) | |
| download | tor-46619ec9143450b181a8510011d3e3fd92542aa4.tar.gz tor-46619ec9143450b181a8510011d3e3fd92542aa4.zip | |
Note some large functions that could be split.
George Kadianakis pointed these out.
| -rw-r--r-- | src/or/entrynodes.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/or/entrynodes.c b/src/or/entrynodes.c index 004081e86c..af1869f045 100644 --- a/src/or/entrynodes.c +++ b/src/or/entrynodes.c @@ -1099,6 +1099,7 @@ entry_guard_is_listed(guard_selection_t *gs, const entry_guard_t *guard) STATIC void sampled_guards_update_from_consensus(guard_selection_t *gs) { + /*XXXX prop271 consider splitting this function up. */ tor_assert(gs); const int REMOVE_UNLISTED_GUARDS_AFTER = (get_remove_unlisted_guards_after_days() * 86400); @@ -1503,6 +1504,7 @@ make_guard_confirmed(guard_selection_t *gs, entry_guard_t *guard) STATIC void entry_guards_update_primary(guard_selection_t *gs) { + /*XXXX prop271 consider splitting this function up. */ tor_assert(gs); // prevent recursion. Recursion is potentially very bad here. @@ -1697,6 +1699,7 @@ entry_guards_note_internet_connectivity(guard_selection_t *gs) STATIC entry_guard_t * select_entry_guard_for_circuit(guard_selection_t *gs, unsigned *state_out) { + /*XXXX prop271 consider splitting this function up. */ tor_assert(gs); tor_assert(state_out); |