summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2016-08-22 10:19:15 -0400
committerNick Mathewson <nickm@torproject.org>2016-08-22 10:19:15 -0400
commit62b239dd9c3c1945a72062223f5b131204ea987a (patch)
treeb4c20712f5e38f156c1fa75950ae762b6a55b3f8
parent3c8baa77a1d2f5a0235adc48ad5650340683e8ee (diff)
parent0ba05313d56e6737c73d003c84eeebdfd0d40398 (diff)
downloadtor-62b239dd9c3c1945a72062223f5b131204ea987a.tar.gz
tor-62b239dd9c3c1945a72062223f5b131204ea987a.zip
Merge branch 'maint-0.2.8'
-rw-r--r--changes/bug199474
-rw-r--r--src/or/routerlist.c4
2 files changed, 6 insertions, 2 deletions
diff --git a/changes/bug19947 b/changes/bug19947
new file mode 100644
index 0000000000..b9dce8b753
--- /dev/null
+++ b/changes/bug19947
@@ -0,0 +1,4 @@
+ o Minor bugfixes (fallback directories):
+ - Avoid logging a NULL string pointer when loading fallback directory information.
+ Fixes bug 19947; bugfix on 0.2.4.7-alpha and 0.2.8.1-alpha.
+ Report and patch by "rubiate".
diff --git a/src/or/routerlist.c b/src/or/routerlist.c
index d713fe4854..efb429532c 100644
--- a/src/or/routerlist.c
+++ b/src/or/routerlist.c
@@ -4544,10 +4544,10 @@ dir_server_new(int is_authority,
if (nickname)
tor_asprintf(&ent->description, "directory server \"%s\" at %s:%d",
- nickname, hostname, (int)dir_port);
+ nickname, hostname_, (int)dir_port);
else
tor_asprintf(&ent->description, "directory server at %s:%d",
- hostname, (int)dir_port);
+ hostname_, (int)dir_port);
ent->fake_status.addr = ent->addr;
tor_addr_copy(&ent->fake_status.ipv6_addr, &ent->ipv6_addr);