summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2017-02-17 11:31:39 -0500
committerNick Mathewson <nickm@torproject.org>2017-02-17 11:31:39 -0500
commit67cec7578cab40ce43b54d4dfc1370894b91d28f (patch)
tree82cc3548b4871479b83e9570deb8b29ccdc8f0f7
parentfea93abecd14b1e95a0bdd894183a81e2c284434 (diff)
downloadtor-67cec7578cab40ce43b54d4dfc1370894b91d28f.tar.gz
tor-67cec7578cab40ce43b54d4dfc1370894b91d28f.zip
Check for micro < 0, rather than checking "minor" twice.
Bug found with clang scan-build. Fixes bug on f63e06d3dc6757d. Bug not present in any released Tor.
-rw-r--r--src/or/routerparse.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/or/routerparse.c b/src/or/routerparse.c
index 7d9769b499..2ee0d2720e 100644
--- a/src/or/routerparse.c
+++ b/src/or/routerparse.c
@@ -5551,7 +5551,7 @@ tor_version_parse_platform(const char *platform,
if (strict) {
if (router_version->major < 0 ||
router_version->minor < 0 ||
- router_version->minor < 0 ||
+ router_version->micro < 0 ||
router_version->patchlevel < 0 ||
router_version->svn_revision < 0) {
return -1;