diff options
| author | Nick Mathewson <nickm@torproject.org> | 2011-11-03 11:52:35 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2011-11-03 11:52:35 -0400 |
| commit | 88c4b425bd49d4cde52fdce7eeb65bcf2304d0f6 (patch) | |
| tree | 5e5f4c2066a8562dd2548617b92a47372afdafa2 | |
| parent | d029c3223ad0d72b8e065c0e92df734185987acf (diff) | |
| download | tor-88c4b425bd49d4cde52fdce7eeb65bcf2304d0f6.tar.gz tor-88c4b425bd49d4cde52fdce7eeb65bcf2304d0f6.zip | |
Fix bug 4367: correctly detect auth_challenge cells we can't use
Found by frosty_un, bugfix on 0.2.3.6-alpha, fix suggested by arma.
| -rw-r--r-- | changes/bug4367 | 5 | ||||
| -rw-r--r-- | src/or/command.c | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/changes/bug4367 b/changes/bug4367 new file mode 100644 index 0000000000..77236d0e61 --- /dev/null +++ b/changes/bug4367 @@ -0,0 +1,5 @@ + o Minor bugfixes: + - Successfully detect AUTH_CHALLENGE cells with no recognized + authentication type listed. Fixes bug 4367; bugfix on 0.2.3.6-alpha. + Found by frosty_un. + diff --git a/src/or/command.c b/src/or/command.c index c02d353bb1..6eb261c370 100644 --- a/src/or/command.c +++ b/src/or/command.c @@ -1100,7 +1100,7 @@ command_process_auth_challenge_cell(var_cell_t *cell, or_connection_t *conn) conn->handshake_state->received_auth_challenge = 1; - if (use_type && public_server_mode(get_options())) { + if (use_type >= 0 && public_server_mode(get_options())) { log_info(LD_OR, "Got an AUTH_CHALLENGE cell from %s:%d: Sending " "authentication", safe_str(conn->_base.address), conn->_base.port); |