summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRoger Dingledine <arma@torproject.org>2014-08-29 16:38:54 -0400
committerRoger Dingledine <arma@torproject.org>2014-08-29 16:38:54 -0400
commit7a878c192f5000c5ef5d29a71924a41b6e5adf42 (patch)
tree9c9730c6a77f8885c81f7230e7835d7f70b2aaaa
parent37a76d75dd38a1ebd45627bb6e29e40f60917188 (diff)
downloadtor-7a878c192f5000c5ef5d29a71924a41b6e5adf42.tar.gz
tor-7a878c192f5000c5ef5d29a71924a41b6e5adf42.zip
Downgrade "Unexpected onionskin length after decryption" warning
It's now a protocol-warn, since there's nothing relay operators can do about a client that sends them a malformed create cell. Resolves bug 12996; bugfix on 0.0.6rc1.
-rw-r--r--changes/bug129965
-rw-r--r--src/or/onion_tap.c5
2 files changed, 8 insertions, 2 deletions
diff --git a/changes/bug12996 b/changes/bug12996
new file mode 100644
index 0000000000..4b4fb0dceb
--- /dev/null
+++ b/changes/bug12996
@@ -0,0 +1,5 @@
+ o Minor bugfixes:
+ - Downgrade "Unexpected onionskin length after decryption" warning
+ to a protocol-warn, since there's nothing relay operators can do
+ about a client that sends them a malformed create cell. Resolves
+ bug 12996; bugfix on 0.0.6rc1.
diff --git a/src/or/onion_tap.c b/src/or/onion_tap.c
index 9a9f374b93..65f8275f75 100644
--- a/src/or/onion_tap.c
+++ b/src/or/onion_tap.c
@@ -122,8 +122,9 @@ onion_skin_TAP_server_handshake(
"Couldn't decrypt onionskin: client may be using old onion key");
goto err;
} else if (len != DH_KEY_LEN) {
- log_warn(LD_PROTOCOL, "Unexpected onionskin length after decryption: %ld",
- (long)len);
+ log_fn(LOG_PROTOCOL_WARN, LD_PROTOCOL,
+ "Unexpected onionskin length after decryption: %ld",
+ (long)len);
goto err;
}