diff options
| author | Nick Mathewson <nickm@torproject.org> | 2008-12-29 14:06:47 +0000 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2008-12-29 14:06:47 +0000 |
| commit | 272b00726827a2344058e28c2b0a1dc43b8f28ce (patch) | |
| tree | 66291b6ddfa315e36218682418ac64944e256c94 | |
| parent | 2c4097e99d10ee14794002a53dc6770ba811de63 (diff) | |
| download | tor-272b00726827a2344058e28c2b0a1dc43b8f28ce.tar.gz tor-272b00726827a2344058e28c2b0a1dc43b8f28ce.zip | |
coverity thinks it's dumb to check networkstatus_v2_list in one place and not another. Coverity has a point, even though the check may be redundant. CID 361.
svn:r17809
| -rw-r--r-- | src/or/routerlist.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/or/routerlist.c b/src/or/routerlist.c index c4de128666..a58976a7e9 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -3265,7 +3265,7 @@ routerlist_remove_old_routers(void) cutoff = now - OLD_ROUTER_DESC_MAX_AGE; /* Build a list of all the descriptors that _anybody_ lists. */ - if (caches) { + if (caches && networkstatus_v2_list) { SMARTLIST_FOREACH(networkstatus_v2_list, networkstatus_v2_t *, ns, { /* XXXX The inner loop here gets pretty expensive, and actually shows up |