diff options
| author | Roger Dingledine <arma@torproject.org> | 2013-05-15 03:34:37 -0400 |
|---|---|---|
| committer | Roger Dingledine <arma@torproject.org> | 2013-05-15 03:34:37 -0400 |
| commit | 0bfaf86612eddbd586d648f3b642dac26f134fca (patch) | |
| tree | 494e8a2f9c917f28ccf0cf2ee397d816de36f8be | |
| parent | aaa3a085db05c4d98b7c51b5ef16da166e7c7f0a (diff) | |
| download | tor-0bfaf86612eddbd586d648f3b642dac26f134fca.tar.gz tor-0bfaf86612eddbd586d648f3b642dac26f134fca.zip | |
Fix socks5 handshake for username/password auth
The fix for bug 8117 exposed this bug, and it turns out real-world
applications like Pidgin do care. Bugfix on 0.2.3.2-alpha; fixes bug 8879.
| -rw-r--r-- | changes/bug8879 | 5 | ||||
| -rw-r--r-- | src/or/buffers.c | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/changes/bug8879 b/changes/bug8879 new file mode 100644 index 0000000000..0d2a70086c --- /dev/null +++ b/changes/bug8879 @@ -0,0 +1,5 @@ + o Major bugfixes: + - Follow the socks5 protocol when offering username/password + authentication. The fix for bug 8117 exposed this bug, and it + turns out real-world applications like Pidgin do care. Bugfix on + 0.2.3.2-alpha; fixes bug 8879. diff --git a/src/or/buffers.c b/src/or/buffers.c index d063d23135..c4c847ec87 100644 --- a/src/or/buffers.c +++ b/src/or/buffers.c @@ -1751,7 +1751,7 @@ parse_socks(const char *data, size_t datalen, socks_request_t *req, return 0; } req->replylen = 2; /* 2 bytes of response */ - req->reply[0] = 5; + req->reply[0] = 1; /* authversion == 1 */ req->reply[1] = 0; /* authentication successful */ log_debug(LD_APP, "socks5: Accepted username/password without checking."); |