summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2011-12-02 16:27:33 -0500
committerNick Mathewson <nickm@torproject.org>2011-12-02 16:27:33 -0500
commit682a85ff7c691f691f9f7745e34e396f15e5d601 (patch)
treeca332882138010131d66e7293703fc7c24f701b3
parent5303918091d832d2986b113d60a6ba1ca328af1c (diff)
downloadtor-682a85ff7c691f691f9f7745e34e396f15e5d601.tar.gz
tor-682a85ff7c691f691f9f7745e34e396f15e5d601.zip
Don't just tell the controller "foo" on id mismatch
Fixes bug 4169; bugfix on 0.2.1.1-alpha.
-rw-r--r--changes/bug41696
-rw-r--r--src/or/connection_or.c4
2 files changed, 9 insertions, 1 deletions
diff --git a/changes/bug4169 b/changes/bug4169
new file mode 100644
index 0000000000..38c18d3bec
--- /dev/null
+++ b/changes/bug4169
@@ -0,0 +1,6 @@
+ o Minor bugfixes:
+ - Report a real bootstrap problem to the controller on router
+ identity mismatch. Previously we just said "foo", which probably
+ made a lot of sense at the time. Fixes bug 4169; bugfix on
+ 0.2.1.1-alpha.
+
diff --git a/src/or/connection_or.c b/src/or/connection_or.c
index 470f6d2a30..b865e13664 100644
--- a/src/or/connection_or.c
+++ b/src/or/connection_or.c
@@ -1514,7 +1514,9 @@ connection_or_client_learned_peer_id(or_connection_t *conn,
control_event_or_conn_status(conn, OR_CONN_EVENT_FAILED,
END_OR_CONN_REASON_OR_IDENTITY);
if (!authdir_mode_tests_reachability(options))
- control_event_bootstrap_problem("foo", END_OR_CONN_REASON_OR_IDENTITY);
+ control_event_bootstrap_problem(
+ "Unexpected identity in router certificate",
+ END_OR_CONN_REASON_OR_IDENTITY);
as_expected = 0;
}
if (authdir_mode_tests_reachability(options)) {