summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2011-09-15 09:51:48 -0400
committerNick Mathewson <nickm@torproject.org>2011-09-15 09:51:48 -0400
commit2394c7401769c56226bd95b70f9b85928a3017de (patch)
treeba93e41992e8e9c1a2024f65054fe303328cb54b
parent6a799c10eed145005b1755c49ea0d9c787df44b7 (diff)
downloadtor-2394c7401769c56226bd95b70f9b85928a3017de.tar.gz
tor-2394c7401769c56226bd95b70f9b85928a3017de.zip
Log errno on listener socket creation failure.
This may help diagnose bug 4027.
-rw-r--r--changes/4027-diagnose4
-rw-r--r--src/or/connection.c3
2 files changed, 6 insertions, 1 deletions
diff --git a/changes/4027-diagnose b/changes/4027-diagnose
new file mode 100644
index 0000000000..3fb6bd012d
--- /dev/null
+++ b/changes/4027-diagnose
@@ -0,0 +1,4 @@
+ o Minor features (diagnostics):
+ - When the system call to create a listener socket fails, log the
+ error message explaining why. This may help diagnose bug 4027.
+
diff --git a/src/or/connection.c b/src/or/connection.c
index 790383b184..009203095e 100644
--- a/src/or/connection.c
+++ b/src/or/connection.c
@@ -891,7 +891,8 @@ connection_create_listener(const struct sockaddr *listensockaddr,
is_tcp ? SOCK_STREAM : SOCK_DGRAM,
is_tcp ? IPPROTO_TCP: IPPROTO_UDP);
if (!SOCKET_OK(s)) {
- log_warn(LD_NET,"Socket creation failed.");
+ log_warn(LD_NET,"Socket creation failed: %s",
+ tor_socket_strerror(tor_socket_errno(-1)));
goto err;
}