diff options
| author | Steven Murdoch <Steven.Murdoch@cl.cam.ac.uk> | 2011-08-30 15:02:28 +0100 |
|---|---|---|
| committer | Steven Murdoch <Steven.Murdoch@cl.cam.ac.uk> | 2011-08-30 15:02:28 +0100 |
| commit | d1dd9991cd636bafe7543aea4dbb18de69f26202 (patch) | |
| tree | 0154e2de13d953b21650cf56056b6fb113b5b624 | |
| parent | da34360952c0fbbd8effc2789ed72b86c8045531 (diff) | |
| download | tor-d1dd9991cd636bafe7543aea4dbb18de69f26202.tar.gz tor-d1dd9991cd636bafe7543aea4dbb18de69f26202.zip | |
Document limitation of log_from_handle with partial reads
| -rw-r--r-- | src/common/util.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/common/util.c b/src/common/util.c index aa344bc9c6..76124ef06c 100644 --- a/src/common/util.c +++ b/src/common/util.c @@ -3654,6 +3654,9 @@ tor_split_lines(smartlist_t *sl, char *buf, int len) #ifdef MS_WINDOWS /** Read from stream, and send lines to log at the specified log level. * Returns -1 if there is a error reading, and 0 otherwise. + * If the generated stream is flushed more often than on new lines, or + * a read exceeds 256 bytes, lines will be truncated. This should be fixed, + * along with the corresponding problem on *nix (see bug #2045). */ static int log_from_handle(HANDLE *pipe, int severity) |