diff options
| author | Nick Mathewson <nickm@torproject.org> | 2012-04-18 23:02:09 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2012-04-18 23:02:09 -0400 |
| commit | f6afd4efa6c24fab8ace710fc0eac4c8811b93dd (patch) | |
| tree | 48365c35949cf0f9d64d54f34314000dfc8a0369 | |
| parent | 2d276ab9d9193d5152fe2599e9d39f2df9ea7d43 (diff) | |
| download | tor-f6afd4efa6c24fab8ace710fc0eac4c8811b93dd.tar.gz tor-f6afd4efa6c24fab8ace710fc0eac4c8811b93dd.zip | |
Fix a log-uninitialized-buffer bug.
Fix for 5647; bugfix on 0.2.1.5-alpha.
| -rw-r--r-- | changes/bug5647 | 4 | ||||
| -rw-r--r-- | src/or/routerparse.c | 3 |
2 files changed, 5 insertions, 2 deletions
diff --git a/changes/bug5647 b/changes/bug5647 new file mode 100644 index 0000000000..92f41c8559 --- /dev/null +++ b/changes/bug5647 @@ -0,0 +1,4 @@ + o Major bugfixes: + - Avoid logging uninitialized data when unable to decode a hidden + service descriptor cookie. Fixes bug 5647; bugfix on 0.2.1.5-alpha. + diff --git a/src/or/routerparse.c b/src/or/routerparse.c index 322a2b5713..8c4f582c07 100644 --- a/src/or/routerparse.c +++ b/src/or/routerparse.c @@ -5056,7 +5056,6 @@ rend_parse_client_keys(strmap_t *parsed_clients, const char *ckstr) while (!strcmpstart(current_entry, "client-name ")) { rend_authorized_client_t *parsed_entry; size_t len; - char descriptor_cookie_base64[REND_DESC_COOKIE_LEN_BASE64+2+1]; char descriptor_cookie_tmp[REND_DESC_COOKIE_LEN+2]; /* Determine end of string. */ const char *eos = strstr(current_entry, "\nclient-name "); @@ -5125,7 +5124,7 @@ rend_parse_client_keys(strmap_t *parsed_clients, const char *ckstr) tok->args[0], REND_DESC_COOKIE_LEN_BASE64+2+1) != REND_DESC_COOKIE_LEN)) { log_warn(LD_REND, "Descriptor cookie contains illegal characters: " - "%s", descriptor_cookie_base64); + "%s", escaped(tok->args[0])); goto err; } memcpy(parsed_entry->descriptor_cookie, descriptor_cookie_tmp, |