diff options
| author | Nick Mathewson <nickm@torproject.org> | 2012-03-30 10:20:48 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2012-03-30 10:20:48 -0400 |
| commit | affbcded5ca03d8e3ccc5debd3c23240e492c62a (patch) | |
| tree | a07d5c0b0ff13beb219661430b9e97e4da6c3c70 | |
| parent | ab3197c0596de087f43c08bda500fcc36ba2ef20 (diff) | |
| download | tor-affbcded5ca03d8e3ccc5debd3c23240e492c62a.tar.gz tor-affbcded5ca03d8e3ccc5debd3c23240e492c62a.zip | |
Fix a memory leak in an error case of SAFECOOKIE authentication.
Found by Coverity Scan; fix for CID 507; bugfix on 0.2.3.13-alpha.
| -rw-r--r-- | changes/memleak_safecookie | 4 | ||||
| -rw-r--r-- | src/or/control.c | 1 |
2 files changed, 5 insertions, 0 deletions
diff --git a/changes/memleak_safecookie b/changes/memleak_safecookie new file mode 100644 index 0000000000..9773af5574 --- /dev/null +++ b/changes/memleak_safecookie @@ -0,0 +1,4 @@ + o Minor bugfixes: + - Fix a small memory leak when trying to decode incorrect base16 + authenticator during SAFECOOKIE authentication. Found by + Coverity Scan. Fixes CID 507. Bugfix on 0.2.3.13-alpha. diff --git a/src/or/control.c b/src/or/control.c index 1eb6b80b80..397bb53ab4 100644 --- a/src/or/control.c +++ b/src/or/control.c @@ -3020,6 +3020,7 @@ handle_control_authchallenge(control_connection_t *conn, uint32_t len, connection_write_str_to_buf("513 Invalid base16 client nonce", conn); connection_mark_for_close(TO_CONN(conn)); + tor_free(client_nonce); return -1; } |