summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2012-01-18 15:29:25 -0500
committerNick Mathewson <nickm@torproject.org>2012-01-18 15:29:25 -0500
commit6d595fa4cf679cf7c66673726596548758a298bc (patch)
treeb5387529ca0622decd9fcdc5313bc38b24a0b0b7
parent676bba8e0c91b7885aa8a9b7f55b008ccccfe282 (diff)
parentdd4b1a2ac605ff53c0eda4ebf44ddd84c3b243c0 (diff)
downloadtor-6d595fa4cf679cf7c66673726596548758a298bc.tar.gz
tor-6d595fa4cf679cf7c66673726596548758a298bc.zip
Merge remote-tracking branch 'public/bug4533_part2' into maint-0.2.2
-rw-r--r--changes/bug4533_part25
-rw-r--r--src/common/compat.h2
2 files changed, 6 insertions, 1 deletions
diff --git a/changes/bug4533_part2 b/changes/bug4533_part2
new file mode 100644
index 0000000000..7e0f7c313e
--- /dev/null
+++ b/changes/bug4533_part2
@@ -0,0 +1,5 @@
+ o Major bugfixes:
+ - Fix the SOCKET_OK test that we use to tell when socket
+ creation fails so that it works on Win64. Fixes part of bug
+ 4533; bugfix on 0.2.2.29-beta. Bug found by wanoskarnet.
+
diff --git a/src/common/compat.h b/src/common/compat.h
index e0b074cf53..d2f1fd1295 100644
--- a/src/common/compat.h
+++ b/src/common/compat.h
@@ -396,7 +396,7 @@ typedef int socklen_t;
#ifdef MS_WINDOWS
#define tor_socket_t intptr_t
-#define SOCKET_OK(s) ((unsigned)(s) != INVALID_SOCKET)
+#define SOCKET_OK(s) ((SOCKET)(s) != INVALID_SOCKET)
#else
#define tor_socket_t int
#define SOCKET_OK(s) ((s) >= 0)