summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2009-07-07 12:19:04 -0400
committerNick Mathewson <nickm@torproject.org>2009-07-07 12:19:04 -0400
commit258b980331f4a6c208144b80df4d4ce7de5caa58 (patch)
tree939fc8b463ff1acc4735c6391d78a2354f5355a8
parent2c221e923b1ff7d8693d8a8b9e6bb5474956349e (diff)
downloadtor-258b980331f4a6c208144b80df4d4ce7de5caa58.tar.gz
tor-258b980331f4a6c208144b80df4d4ce7de5caa58.zip
Make "Invalid onion hostname" msg respect SafeLogging.
Patch by Roger; fixes bug 1027.
-rw-r--r--ChangeLog4
-rw-r--r--src/or/connection_edge.c3
2 files changed, 5 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index a3199c787e..d368871079 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,4 @@
-Changes in version 0.2.1.17-rc - 2009-07-02
+Changes in version 0.2.1.17-rc - 2009-07-07
o Major features:
- Clients now use the bandwidth values in the consensus, rather than
the bandwidth values in each relay descriptor. This approach opens
@@ -36,6 +36,8 @@ Changes in version 0.2.1.17-rc - 2009-07-02
- When we can't find an intro key for a v2 hidden service descriptor,
fall back to the v0 hidden service descriptor and log a bug message.
Workaround for bug 1024.
+ - Fix a log message that did not respect the SafeLogging option.
+ Resolves bug 1027.
o Minor features:
- If we're a relay and we change our IP address, be more verbose
diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c
index 1ef87dbffa..d699591cdc 100644
--- a/src/or/connection_edge.c
+++ b/src/or/connection_edge.c
@@ -1484,7 +1484,8 @@ connection_ap_handshake_rewrite_and_attach(edge_connection_t *conn,
addresstype = parse_extended_hostname(socks->address);
if (addresstype == BAD_HOSTNAME) {
- log_warn(LD_APP, "Invalid hostname %s; rejecting", socks->address);
+ log_warn(LD_APP, "Invalid onion hostname %s; rejecting",
+ safe_str(socks->address));
control_event_client_status(LOG_WARN, "SOCKS_BAD_HOSTNAME HOSTNAME=%s",
escaped(socks->address));
connection_mark_unattached_ap(conn, END_STREAM_REASON_TORPROTOCOL);