Backport: Be even _more_ careful when signatures are bogus.

svn:r17253

1 files changed, 6 insertions, 1 deletions

diff --git a/src/or/dirvote.c b/src/or/dirvote.c
index 6fc234bd34..6706c8047b 100644
--- a/src/or/dirvote.c
+++ b/src/or/dirvote.c
@@ -1877,7 +1877,12 @@ dirvote_add_signatures_to_pending_consensus(
       networkstatus_get_detached_signatures(pending_consensus);
     const char *src;
     char *dst, *dst_end;
-    size_t new_consensus_len =
+    size_t new_consensus_len;
+    if (!new_detached) {
+      *msg_out = "No signatures to add";
+      goto err;
+    }
+    new_signatures_len =
       strlen(pending_consensus_body) + strlen(new_detached) + 1;
     pending_consensus_body = tor_realloc(pending_consensus_body,
                                          new_consensus_len);