diff options
| author | Nick Mathewson <nickm@torproject.org> | 2007-03-03 21:55:31 +0000 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2007-03-03 21:55:31 +0000 |
| commit | 5f9f62daa29a58ba855c8318f814eb527ae38066 (patch) | |
| tree | bc887db2e8eca3125bf2e93687825ff56b2f564d | |
| parent | 25508347ec566b4060fc61720139f79814d58415 (diff) | |
| download | tor-5f9f62daa29a58ba855c8318f814eb527ae38066.tar.gz tor-5f9f62daa29a58ba855c8318f814eb527ae38066.zip | |
r12053@catbus: nickm | 2007-03-03 16:45:38 -0500
Remove some XXX012s: leave a check in connection_or_set_identity_digest it costs basically nothing to do on average. Forget about reinstating the user check on NT Service creation. Note that a notice message in main.c ("Is something wrong with your network connection?") is really useless.
svn:r9721
| -rw-r--r-- | src/or/connection_or.c | 1 | ||||
| -rw-r--r-- | src/or/main.c | 4 |
2 files changed, 3 insertions, 2 deletions
diff --git a/src/or/connection_or.c b/src/or/connection_or.c index 34c890b5ae..13d37fee0c 100644 --- a/src/or/connection_or.c +++ b/src/or/connection_or.c @@ -113,7 +113,6 @@ connection_or_set_identity_digest(or_connection_t *conn, const char *digest) conn->next_with_same_id = tmp; #if 1 - /*XXXX012 change this back to if 0. */ /* Testing code to check for bugs in representation. */ for (; tmp; tmp = tmp->next_with_same_id) { tor_assert(!memcmp(tmp->identity_digest, digest, DIGEST_LEN)); diff --git a/src/or/main.c b/src/or/main.c index 9f655b6d53..17e1f3e74c 100644 --- a/src/or/main.c +++ b/src/or/main.c @@ -536,6 +536,8 @@ conn_close_if_marked(int i) severity = LOG_INFO; else severity = LOG_NOTICE; + /* XXXX012 rewrite this error message; it generates lots of worried + * support requests. */ log_fn(severity, LD_NET, "Something wrong with your network connection? " "We tried to write %d bytes to addr %s (fd %d, type %s, state %d)" " but timed out. (Marked at %s:%d)", @@ -2278,7 +2280,7 @@ nt_service_install(int argc, char **argv) NULL, &sidLen, // Don't care about the SID NULL, &domainLen, // Don't care about the domain &sidUse) == 0) { - /* XXXX012 For some reason, the above test segfaults. Fix that. */ + /* XXXX For some reason, the above test segfaults. Fix that. */ printf("User \"%s\" doesn't seem to exist.\n", user_acct); return -1; } else { |