summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRoger Dingledine <arma@torproject.org>2005-07-12 23:21:15 +0000
committerRoger Dingledine <arma@torproject.org>2005-07-12 23:21:15 +0000
commit4457c181f50b5bc3bb57f2d9ba73492e5b9eaa3f (patch)
tree44795b2f2624c6498dac37072a6bec32366730b5
parentddecb1a04d7cf0e14ede95d5dc2647e9b95c9a77 (diff)
downloadtor-4457c181f50b5bc3bb57f2d9ba73492e5b9eaa3f.tar.gz
tor-4457c181f50b5bc3bb57f2d9ba73492e5b9eaa3f.zip
note a worrying double-free possibility in torgzip.
nick? svn:r4537
-rw-r--r--src/common/torgzip.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/common/torgzip.c b/src/common/torgzip.c
index 8d4438907d..453ce6d8f3 100644
--- a/src/common/torgzip.c
+++ b/src/common/torgzip.c
@@ -208,7 +208,7 @@ tor_gzip_uncompress(char **out, size_t *out_len,
*out_len = stream->total_out;
if (inflateEnd(stream)!=Z_OK) {
log_fn(LOG_WARN, "Error freeing gzip structures");
- goto err;
+ goto err; /* XXX this will try to inflateEnd again, right? is that bad? */
}
tor_free(stream);