diff options
| author | Roger Dingledine <arma@torproject.org> | 2005-06-26 05:03:21 +0000 |
|---|---|---|
| committer | Roger Dingledine <arma@torproject.org> | 2005-06-26 05:03:21 +0000 |
| commit | 09e87f452d9bcfd0849c867a22695960c62a1779 (patch) | |
| tree | 672bd8a5ea484df72847385719c07e4c366b56cf | |
| parent | e64b016b558f9ec6e4e848e0cce183be793fb565 (diff) | |
| download | tor-09e87f452d9bcfd0849c867a22695960c62a1779.tar.gz tor-09e87f452d9bcfd0849c867a22695960c62a1779.zip | |
note a bug in our tor_socketpair implementation
can somebody fix this or create a flyspray entry for it?
svn:r4483
| -rw-r--r-- | src/common/compat.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/common/compat.c b/src/common/compat.c index 5f8f35d752..7f0823bbe1 100644 --- a/src/common/compat.c +++ b/src/common/compat.c @@ -291,6 +291,10 @@ set_socket_nonblocking(int socket) * stack is down). And even if it succeeds, the socket pair will not * be able to read while localhost is down later (the socket pair may * even close, depending on OS-specific timeouts). + * + * XXX Bug: this function assumes errno is how you report errors, but + * that isn't the case for Windows, which is where it's most likely + * to be called. **/ int tor_socketpair(int family, int type, int protocol, int fd[2]) |