diff options
| author | Nick Mathewson <nickm@torproject.org> | 2020-07-01 10:33:27 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2020-07-01 10:33:27 -0400 |
| commit | 5d956d797bb42156eae8fa3063c68bccbc6734e7 (patch) | |
| tree | 2e66d5fedab97e68108d444e414207197b413626 | |
| parent | 2238b6320b6e33b5c661012fcbe6831b42a8e123 (diff) | |
| download | tor-5d956d797bb42156eae8fa3063c68bccbc6734e7.tar.gz tor-5d956d797bb42156eae8fa3063c68bccbc6734e7.zip | |
Add a comment explaining reachability vs bandwidth self-tests
This is in response to a question about why we don't always log
orport self-tests as reachability tests.
I'm not 100% convinced that bandwidth self-tests are still useful,
but that's an issue for another day. :)
| -rw-r--r-- | src/feature/relay/selftest.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/feature/relay/selftest.c b/src/feature/relay/selftest.c index 6420b29fbf..101704e1c9 100644 --- a/src/feature/relay/selftest.c +++ b/src/feature/relay/selftest.c @@ -259,6 +259,9 @@ router_do_orport_reachability_checks(const routerinfo_t *me, !orport_reachable ? "reachability" : "bandwidth", family_name, fmt_addrport(&ei->addr, ei->port)); if (!orport_reachable) { + /* This is only a 'reachability test' if we don't already think that + * the port is reachable. If we _do_ think it's reachable, then + * it counts as a 'bandwidth test'. */ inform_testing_reachability(&ei->addr, ei->port, false); } circuit_launch_by_extend_info(CIRCUIT_PURPOSE_TESTING, ei, |