diff options
| author | Nick Mathewson <nickm@torproject.org> | 2017-03-06 11:31:11 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2017-03-06 11:31:11 -0500 |
| commit | 5203cd2f11a1419db57d067d2713c2118787d0c3 (patch) | |
| tree | 3dfdf11b63d507e4d23e3a135ff2097e11d294f3 | |
| parent | 0a54e5d1481b9d641f5e9e1876818838175485f4 (diff) | |
| download | tor-5203cd2f11a1419db57d067d2713c2118787d0c3.tar.gz tor-5203cd2f11a1419db57d067d2713c2118787d0c3.zip | |
Check for NULL as input to extrainfo_parse_entry_from_string()
We hope this will make the clangalyzer less worried about this function.
Closes ticket 21496.
| -rw-r--r-- | changes/bug21496 | 4 | ||||
| -rw-r--r-- | src/or/routerparse.c | 3 |
2 files changed, 7 insertions, 0 deletions
diff --git a/changes/bug21496 b/changes/bug21496 new file mode 100644 index 0000000000..24ac85a769 --- /dev/null +++ b/changes/bug21496 @@ -0,0 +1,4 @@ + o Minor features (safety): + - Add an explict check to extrainfo_parse_entry_from_string() for NULL + inputs. We don't believe this can actually happen, but it may help + silence a warning from the Clang analyzer. Closes ticket 21496. diff --git a/src/or/routerparse.c b/src/or/routerparse.c index 0336c035b4..c4f329513c 100644 --- a/src/or/routerparse.c +++ b/src/or/routerparse.c @@ -2030,6 +2030,9 @@ extrainfo_parse_entry_from_string(const char *s, const char *end, * parse that's covered by the hash. */ int can_dl_again = 0; + if (BUG(s == NULL)) + return NULL; + if (!end) { end = s + strlen(s); } |