aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Goulet <dgoulet@torproject.org>2022-08-02 16:08:50 -0400
committerDavid Goulet <dgoulet@torproject.org>2022-08-02 16:08:50 -0400
commita1ff71c061ec675b1df09862193fe89abefa0f3e (patch)
treea78f57265a9668943a85979dde2d5929763557da
parent6bd3d3fe70da223ae5cd1e2cdd5e08f4ccb0df9a (diff)
parent0c984e0ec25ddb6245dc36080565500aa1a62be6 (diff)
downloadtor-a1ff71c061ec675b1df09862193fe89abefa0f3e.tar.gz
tor-a1ff71c061ec675b1df09862193fe89abefa0f3e.zip
Merge branch 'maint-0.4.5' into release-0.4.5
-rw-r--r--changes/ticket406045
-rw-r--r--src/core/or/connection_or.c4
2 files changed, 9 insertions, 0 deletions
diff --git a/changes/ticket40604 b/changes/ticket40604
new file mode 100644
index 0000000000..ec24a46e66
--- /dev/null
+++ b/changes/ticket40604
@@ -0,0 +1,5 @@
+ o Major bugfixes (relay):
+ - Remove OR connections btrack subsystem entries when the connections
+ closes normally. Before this, we would only close it on error and thus
+ leaking memory for each normal OR connections. Fixes bug 40604; bugfix
+ on 0.4.0.1-alpha.
diff --git a/src/core/or/connection_or.c b/src/core/or/connection_or.c
index e3e81ed9cb..0cd3c058ec 100644
--- a/src/core/or/connection_or.c
+++ b/src/core/or/connection_or.c
@@ -799,6 +799,10 @@ connection_or_about_to_close(or_connection_t *or_conn)
} else if (!tor_digest_is_zero(or_conn->identity_digest)) {
connection_or_event_status(or_conn, OR_CONN_EVENT_CLOSED,
tls_error_to_orconn_end_reason(or_conn->tls_error));
+ } else {
+ /* Normal close, we notify of a done connection. */
+ connection_or_event_status(or_conn, OR_CONN_EVENT_CLOSED,
+ END_OR_CONN_REASON_DONE);
}
}