aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2021-03-24 12:25:05 -0400
committerNick Mathewson <nickm@torproject.org>2021-03-24 12:25:05 -0400
commit44df63e591feec5d5ae5c4a838664997bc64f489 (patch)
tree58f6f4edf0ffe438b6ad1506f907d00be6ef459c
parenta93f7363378f90a2faf98f7a3e67707b1be37362 (diff)
parent9ca2394d6b51242bb5cf380757be5869d2a44c3c (diff)
downloadtor-44df63e591feec5d5ae5c4a838664997bc64f489.tar.gz
tor-44df63e591feec5d5ae5c4a838664997bc64f489.zip
Merge branch 'maint-0.4.4' into release-0.4.4
-rw-r--r--changes/ticket403455
-rw-r--r--src/core/or/channel.c2
2 files changed, 6 insertions, 1 deletions
diff --git a/changes/ticket40345 b/changes/ticket40345
new file mode 100644
index 0000000000..246e4a86af
--- /dev/null
+++ b/changes/ticket40345
@@ -0,0 +1,5 @@
+ o Minor bugfixes (channel, DoS):
+ - Fix a possible non fatal assertion BUG() due to a too early free of a
+ string when noting down the client connection for the DoS defenses
+ subsystem. Fixes bug 40345; bugfix on 0.4.3.4-rc
+
diff --git a/src/core/or/channel.c b/src/core/or/channel.c
index 9194718e3d..50c03de846 100644
--- a/src/core/or/channel.c
+++ b/src/core/or/channel.c
@@ -1887,11 +1887,11 @@ channel_do_open_actions(channel_t *chan)
geoip_note_client_seen(GEOIP_CLIENT_CONNECT,
&remote_addr, transport_name,
now);
- tor_free(transport_name);
/* Notify the DoS subsystem of a new client. */
if (tlschan && tlschan->conn) {
dos_new_client_conn(tlschan->conn, transport_name);
}
+ tor_free(transport_name);
}
/* Otherwise the underlying transport can't tell us this, so skip it */
}