aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2017-12-11 16:56:31 -0500
committerNick Mathewson <nickm@torproject.org>2017-12-11 16:56:31 -0500
commit5a8e902651001f20a00da7c78e69842ed13180c3 (patch)
tree4b206a53fe7b7022987ed322f6755ac86602293e
parentb077ccde4e890110ddfa9304d5badf261a2942b9 (diff)
parentf7151387d937bd1113f4c694b170305d80dde9fa (diff)
downloadtor-5a8e902651001f20a00da7c78e69842ed13180c3.tar.gz
tor-5a8e902651001f20a00da7c78e69842ed13180c3.zip
Merge branch 'maint-0.2.8' into release-0.2.8
-rw-r--r--changes/bug241677
-rw-r--r--src/or/connection.c4
2 files changed, 11 insertions, 0 deletions
diff --git a/changes/bug24167 b/changes/bug24167
new file mode 100644
index 0000000000..fd0d87efff
--- /dev/null
+++ b/changes/bug24167
@@ -0,0 +1,7 @@
+ o Minor bugfixes (network layer):
+ - When closing a connection via close_connection_immediately(), we
+ mark it as "not blocked on bandwidth", to prevent later calls
+ from trying to unblock it, and give it permission to read. This
+ fixes a backtrace warning that can happen on relays under various
+ circumstances. Fixes bug 24167; bugfix on 0.1.0.1-rc.
+
diff --git a/src/or/connection.c b/src/or/connection.c
index 4fbbaf1abd..05e56c1a52 100644
--- a/src/or/connection.c
+++ b/src/or/connection.c
@@ -754,6 +754,10 @@ connection_close_immediate(connection_t *conn)
connection_unregister_events(conn);
+ /* Prevent the event from getting unblocked. */
+ conn->read_blocked_on_bw =
+ conn->write_blocked_on_bw = 0;
+
if (SOCKET_OK(conn->s))
tor_close_socket(conn->s);
conn->s = TOR_INVALID_SOCKET;